Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep SentryHttpClientException name from obfuscation #3093

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Keep SentryHttpClientException name from obfuscation #3093

merged 2 commits into from
Dec 13, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Dec 12, 2023

📜 Description

💡 Motivation and Context

Came up in internal discussion

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 390.61 ms 475.44 ms 84.83 ms
Size 1.72 MiB 2.27 MiB 554.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d6d2b2e 413.20 ms 486.76 ms 73.56 ms
0bd723b 412.52 ms 496.65 ms 84.13 ms
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
b172d4e 352.92 ms 446.50 ms 93.58 ms
4bf95dd 345.96 ms 414.24 ms 68.28 ms
4e260b3 388.40 ms 468.98 ms 80.58 ms
93a76ca 377.96 ms 447.52 ms 69.56 ms
bc4be3b 360.40 ms 435.04 ms 74.64 ms
283d83e 348.44 ms 392.06 ms 43.62 ms
93a76ca 397.30 ms 455.16 ms 57.87 ms

App size

Revision Plain With Sentry Diff
d6d2b2e 1.72 MiB 2.27 MiB 555.05 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
b172d4e 1.72 MiB 2.29 MiB 578.09 KiB
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
bc4be3b 1.72 MiB 2.29 MiB 576.53 KiB
283d83e 1.72 MiB 2.29 MiB 577.69 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB

@romtsn romtsn merged commit 82884cb into main Dec 13, 2023
16 of 19 checks passed
@romtsn romtsn deleted the rz/fix/http-exception-proguard-rule branch December 13, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romtsn @markushi